Skip to content

Fix missing space in order statistics warning message#330

Merged
jgabry merged 2 commits intostan-dev:masterfrom
ishaan-arora-1:fix/missing-space-in-order-stat-warning
Feb 27, 2026
Merged

Fix missing space in order statistics warning message#330
jgabry merged 2 commits intostan-dev:masterfrom
ishaan-arora-1:fix/missing-space-in-order-stat-warning

Conversation

@ishaan-arora-1
Copy link
Contributor

Fixes #329

R's warning() concatenates string arguments with no separator, so the two sentences in the loo_order_stat_check() warning were getting glued together as "chance.See".

Added the missing trailing space after the first sentence.

Also tightened the existing test to check the full message text.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Merging now.

@jgabry jgabry merged commit aab19c9 into stan-dev:master Feb 27, 2026
6 checks passed
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (2883f25) to head (7f66ea0).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          31       31           
  Lines        2992     2992           
=======================================
  Hits         2776     2776           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing space in loo_compare order statistics warning message

3 participants