fix: pin figlet to 1.8.1 and harden banner against load failures#48
Merged
general-maximus-decimus merged 1 commit intoJul 13, 2026
Merged
Conversation
There was a problem hiding this comment.
🤖 StallionDevX AI Review
Quality Score: ██████████ 95/100
Verdict: approve
Summary
This pull request significantly improves the robustness of the CLI banner display by pinning the figlet dependency and implementing a graceful fallback mechanism. If figlet fails to render the banner, it now defaults to a plain wordmark instead of potentially crashing or showing an error, enhancing user experience. The changes are well-contained and address a potential point of failure effectively.
⚠️ Warning (1)
- 🧹 Swallowing Error in Banner Fallback —
src/utils/banner.ts:32
Thecatchblock forrenderFigletBannercurrently swallows any error without logging it. While the fallback to a plain wordmark is good for user experience, logging the error (e.g., at a debug or warning level) could be beneficial for diagnosing issues if thefigletbanner consistently fails in certain environments.
Thor963
approved these changes
Jul 13, 2026
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
figlet 1.9.0+ ships a broken CommonJS build (import.meta.url → undefined), so require("figlet") threw on load and killed the CLI on every command. Our ^1.7.0 range let fresh installs pull 1.11.1
Fixed two ways: