Repository navigation
refactor(skill): serve the Procedure from the binary behind a thin Bootstrap skill - #182
Conversation
Measurements: darwin/amd64 17625952, darwin/arm64 16017186, linux/amd64 17322144, linux/arm64 15663264, windows/amd64 17714176, windows/arm64 15795712 bytes. Raised only the five crossed lines to the next 10 kB.
🦋 Changeset detectedLatest commit: f76d632 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedToo many files! This PR contains 210 files, which is 110 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
Summary
The installed skill becomes a thin Bootstrap skill. The Procedure moves into the binary, so the instructions an agent reads always match the binary that checks its work (ADR-0006, STA-445 PR 1b).
The shim never runs a binary from the reviewed checkout, such as a committed
node_modules/.bin/verdict. A hostile PR cannot supply its own judge.TestBootstrapSkillStaysThinkeeps the stub from growing back into a Procedure. It checks:name,descriptionand an integerstub_version;verdict skillandverdict post;review.schema.jsonproperty names.GLOSSARY.mdat the repo root defines Procedure, Bootstrap skill and Bundle.Evidence
skill installcopied 22 files, including the full Procedure. A copy went stale as soon as the binary changed.After:
skill install --dirwritesSKILL.md,NOTICE.md,scripts/verdictand.verdict-managed.verdict skill show prompts/review.mdis byte-identical toprocedure/prompts/review.md.shim ignores a binary committed to the reviewed treeexits 1 withmissing-go-binaryand empty stdout, with a committednode_modules/.bin/verdictpresent.TestBootstrapSkillStaysThinrule was mutation-checked and fails when broken.skill statusreadsstub_versionfromSKILL.mdand still comparesNOTICE.mdand the shim byte for byte. A deleted shim exits 1, and aSKILL.mdbody edit exits 0. A six-case table covers this and fails when the old clear-all behavior is restored.statusexits 0.uninstallnow owns only the stub files, so it cannot clear the old Procedure.fetch-local→run --agent pi→record→report --check, all local) found the status bug and the reinstall bug; both are fixed here.f76d63214, all exit 0:make test-racemake evals(142 passed)make vetgo vetmake deadcodemake crossschemas-checkts-types-checkclients-tsmake sizegofmtMerge Danger
Door: two-way
The change is a revert away. No stored data or published schema changes.
Blast Radius: installed-skills
Existing installs keep the old full skill until they reinstall. The changeset is listed under Breaking changes and gives a reinstall that clears the old directory. The run/drain directive still says to read the installed skill; PR 2 moves it to the bundle's
procedure.md. linux/arm64 grows by 65,536 B, one 64 KiB page-alignment step.