Repository navigation
feat(drain): preview replies with --post --dry-run (STA-444) - #180
Merged
Merged
Conversation
Run the real post gates and live reads, then write drain.dryrun.json with the final marked bodies instead of posting or mutating the receipt. The preview schema ships under schemas/ with the new-style $id. Size baselines raised to the next 10 kB: darwin/amd64 17617712, darwin/arm64 16017138, linux/amd64 17309856, windows/amd64 17705472, windows/arm64 15787008.
🦋 Changeset detectedLatest commit: 4c820a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STA-444:
verdict drain <repo> <pr> --post --dry-runpreviews exactly what--postwould write, with zero host writes. This closes north star amendment A4 ("every host write has an explicit verb or flag, a dry-run, and a receipt"), wheredrainwas the only outlier.--dry-runwithout--post→ exit 2. It composes with--agent: plan → draft → preview.schemas/drain-dryrun.schema.json. It is separate fromdrain.json, so a preview can never be mistaken for a receipt. TS types are regenerated.--dry-run, and the completion guard covers it.Evidence
replies.json,drain.jsonandthreads.jsonstay byte-identical;--dry-runwithout--postexits 2.drain-post: D1 is the dry run reporting both marked bodies. D5 shows "the real post sent exactly the bodies the dry run planned", with the stub refusing unregistered argv across all runs.770b32f7e: all green.make test-race,make vet,GOOS=windows go vet,make deadcode,make cross, doc-coverage,make schemas-check,make ts-types-check,make clients-tsandmake sizepass.make evals: 142 passed.golangci-lint(host and windows): 0 issues.Merge Danger
Door: two-way
This is a new opt-in flag. Existing
drainbehavior is unchanged.Blast Radius: small
The binary grows by about 10–20 KB per target; five size budgets rose to the next 10 KB, with measurements in the commit body.