Repository navigation
feat(drain): post replies to waiting review threads (STA-351 PR B) - #175
Conversation
Measured with make size before the bump: darwin/amd64 17529360 (budget 17500000) darwin/arm64 15932226 (budget 15900000) linux/amd64 17223840 (budget 17190000) linux/arm64 15597728 (budget 15600000) windows/amd64 17619968 (budget 17590000) windows/arm64 15711744 (budget 15680000) deps 0 (budget 0)
…re draft preflight
…ck post run, and emit single incomplete envelope
darwin/amd64: 17537552 -> 17540000 linux/amd64: 17232032 -> 17240000 windows/amd64: 17626112 -> 17630000
|
Important Review skippedToo many files! This PR contains 144 files, which is 44 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
🦋 Changeset detectedLatest commit: 32a54a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary
STA-351 PR B of 2:
verdict drain --postanswers pending review-thread replies on the host. PR A (#174) added plan and drafts. Spec: STA-351 spec —verdict drain.drain R N --agent A --postplans, drafts, validates and posts in one run.author_kind: verdict, so the next run sees the thread as answered.provider-unimplementedbefore any read.drainis now listed inSKILL.md. That moves only theprompts_hashlines, therun_idand byte counts derived from it, and the provenance pin.Evidence
--postwas an unknown flag.drain-post(answer + withdraw post 2 marked replies and 1 resolve; the ledger has 2 entries; the rerun makes 0 writes; the one-run--agent --postpath works) anddrain-stale.drain-refusalsadds a secret-shaped body and a Forgejo--post(0 writes each).TestPostPartialFailureRerunIsIdempotentTestPostLocalRefusalsMakeZeroHostCallsAndKeepThreadsUnchangedTestPostCallOrderLocalChecksThenReadsThenWritesTestPostConcurrentRunsSerialize(fails 3/3 runs without the lock)TestPostIncompleteEmitsSingleJSONEnvelopeTestReplyMarkerRoundTripnextomitted--post; host reads came before the local checks; there were two JSON envelopes.81832f89b: all green.make test-race,make vet,make deadcode,make cross, doc-coverage,make schemas-check,make ts-types-check,make tsgen && make build && make clients-tsandmake sizepass.make evals: 140 passed, 0 failed.golangci-lint(host andGOOS=windows): 0 issues.Merge Danger
Door: two-way
--postis opt-in, and it is the only path in this PR that writes to a host. Plan and draft modes are unchanged from #174.Blast Radius: small
--post, after the secret scan and stale checks.SKILL.mdhashes move in about 104 goldens.Follow-ups (advisory):
drain.jsonposted[]reflects only the last--postrun;replies.jsonis the durable record.