Repository navigation
fix(verify): write .verify.out owner-only - #165
Conversation
`.verify.out` holds the command's raw combined output, so a command that prints a credential leaves the value in it, and the store writer's 0644 left that readable by every local user. Write it at 0600, the permission `run` already gives `.run.out`; the recorded tail in `patch.json` and the deep-validation receipts stay redacted and 0644 as before. Add `.WriteFileMode(` to wrapcheck's ignore-sigs beside `.WriteFile(`: both seal their errors at the store boundary (GO-ERRORS-03).
🦋 Changeset detectedLatest commit: 9678329 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Fixes STA-432. Part of STA-436 (release 0.7.0).
What
verifywrote.verify.out, the raw combined stdout and stderr of the verify command, at the store's 0644 mode. Any credential the command printed was readable by other local users. The file is now written owner-only (0600), the same asrun's.run.out.The raw content is intentional, for operator debugging, and existing tests pin it (
TestVerifyRedaction,TestVerifyContractRedaction). The published receipts (patch.jsonandverification-<group>.json) were already redacted and are unchanged. Nothing outsideinternal/core/verifywrites the file or sweeps it into a posted artifact.Evidence
TestVerifyOutputOwnerOnlyfailed on main with.verify.out mode = 0644, want 0o600, and reverting the fix brings that failure back. The mode check is skipped on Windows, where permission bits aren't real.make evals135/135, whole-repogo test, golangci-lint (native andGOOS=windows),make crossandmake sizepass.Summary by CodeRabbit