Skip to content

chore: bump Vite+ to 1.5.0 and keep the lock on version bumps - #19

Merged
SutuSebastian merged 1 commit into
mainfrom
chore/vite-plus-1.5.0
Nov 6, 2026
Merged

SutuSebastian merged 1 commit into
mainfrom
chore/vite-plus-1.5.0

Conversation

@SutuSebastian

@SutuSebastian SutuSebastian commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Bumps the workspace to the published Vite+ 1.5.0 line: vite-plus and its vite core alias to 1.5.0, vitest and @vitest/coverage-v8 to 5.1.0. setup-vp moves to v1.22.0, which resolves the version from the catalog, so CI and local runs use the same binary. Bun is already on 1.4.4, the latest release.

The version script no longer deletes bun.lock before reinstalling. A full re-resolution hoists @emnapi/runtime@2.0.0-beta.2 from @rolldown/binding-wasm32-wasi above @astrojs/astro2tsx, whose pinned @emnapi/core@1.11.3 has no bridge.setLastError, so blume check crashes and the required Docs site check fails on the Version PR (reproduced locally after changeset version). A plain bun install still refreshes the workspace versions that the frozen install verifies, and the Version flow then touches only 3 lines of the lock.

Verified: bun run check, 901 tests, bun run pack, the docs typecheck, and a full bun run version rehearsal in a worktree with bun install --frozen-lockfile and blume check green.

Summary by CodeRabbit

  • Chores
    • Updated project tooling and package versions.
    • Version updates now preserve the existing lockfile during package installation.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge; no actionable issues were found.

Summary

Updates Vite+ and keeps the existing dependency lock during version bumps.

  • The workspace and CI use the Vite+ 1.5.0 toolchain.
  • The version script keeps the Bun lockfile in place.

Reviews (1) · Last reviewed commit: "chore: bump Vite+ to 1.5.0 and keep the ..." · Reviewed by Greptile

The catalog moves vite-plus and its vite core alias to 1.5.0, with the
matching vitest and coverage line at 5.1.0. setup-vp moves to v1.22.0; it
auto-detects the catalog entry, so CI installs the same 1.5.0 the
workspace pins. Bun stays at 1.4.4, already latest.

The version script also stops deleting bun.lock before reinstalling. On a
full re-resolution the graph hoists @emnapi/runtime@2.0.0-beta.2 from
@rolldown/binding-wasm32-wasi above @astrojs/astro2tsx, whose pinned
@emnapi/core@1.11.3 has no bridge.setLastError, so `blume check` crashes
and the required Docs site check fails on the Version PR. A plain
`bun install` after `changeset version` still refreshes the workspace
versions that the frozen install verifies, without re-resolving the graph.
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Setup Vite+ action reference and package catalog versions are updated. The version script no longer deletes bun.lock before running bun install.

Changes: Toolchain Updates

Layer / File(s) Summary
Toolchain versions and installation behavior
.github/actions/setup/action.yml, package.json
The Setup Vite+ action reference changes to v1.22.0. The catalog updates @vitest/coverage-v8 and vitest to 5.1.0, and vite and vite-plus to 1.5.0. The version script runs bun install without first deleting bun.lock.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Minimal · up to fcb37

No actionable merge-blocking risk is identified in these changes; merge after normal checks pass.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the Vite+ upgrade and the change to retain the lockfile during version bumps.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e45863ec-7942-4810-a653-e2a021ccba8b
Commits

Reviewing files that changed from the base of the PR and between 0c70748 and fcb371f.

Files ignored due to path filters: 1

  • bun.lock is excluded by !**/*.lock
Files selected for processing: 2

  • .github/actions/setup/action.yml
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@changeset-bot

changeset-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fcb371f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes
Reviewed the Vite+ 1.5.0 bump and the version script fix in this run.

  • Toolchain bump to Vite+ 1.5.0: catalog entries for vite-plus, vite, vitest, and @vitest/coverage-v8 move to the 1.5.0 / 5.1.0 line, with the lockfile carrying the matching transitive bumps (oxlint, oxfmt, vitest family, platform bindings).
  • CI setup action to v1.22.0: setup-vp moves from v1.21.2 to v1.22.0, keeping CI and local runs on the same binary per the PR description.
  • version script keeps the lock: drops rm -f bun.lock so changeset version is followed by a plain bun install, avoiding the full re-resolution that hoisted @emnapi/runtime and broke blume check.

The lockfile diff is consistent with the catalog (no version skew), and the version script change is the safer default: a plain install still records the workspace version bumps while leaving unrelated transitive pins stable.

Pullfrog  | View workflow run | Using muse-spark-1.3-contributor | 𝕏

@SutuSebastian
SutuSebastian merged commit 891dabe into main Nov 6, 2026
11 checks passed
@SutuSebastian
SutuSebastian deleted the chore/vite-plus-1.5.0 branch November 6, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant