SIP-045 PoX-5: Bitcoin Staking and Emission Schedule Alignment - #270
Conversation
|
Editors, can we go ahead and assign SIP number 045 for this proposal? |
Please let me know once SIP ID assigned so we can display on the SIP Tracker (https://www.zeroauthoritydao.com/sip) and prepare CAB Group voting (https://www.zeroauthoritydao.com/sip/cab-groups) |
clairetopalian
left a comment
There was a problem hiding this comment.
Approved - awaiting 2nd review so we can assign SIP #
314159265359879
left a comment
There was a problem hiding this comment.
Thank you for submitting such a high quality draft!
Let me start by signing off on using SIP-045 for this.
I would like to see a few changes before moving to editor sign-off. I have added suggestions with my comments I hope they help clarify and resolve.
The section 6 and 3 comments are high priority the rest can be considered medium to low priority.
Section 9: Emissions and total max STX supply at block spreadsheet
I would like to see an updated spreadsheet included with this sip similar to the one with SIP029. Preferably one that includes the Endowment emissions and the emissions per block (and/or per cycle) upto 2050 to reflect total STX supply at certain moments.
The first tab in the spreadsheet can be condensed to show the STX supply at the time of the next 4 bitcoin halvings and on January 2050 as the SIP029 appendix does does (for easy comparison): https://github.com/stacksgov/sips/blob/main/sips/sip-029/sip-029-4.xlsx other tabs can be used to display emisssions per block and/or per stacking cycle.
Supplies would be approximations, there is likely to be some burning of STX for example due to BNS or in case the endowment doesn't need all its funds and burns some, that is fine. We've always called it "maximum expected supply".
|
Question out of curiosity Section 7 mentions SIP-032 but doesn't explicitly mention what was incorporated in PoX-5. My comparison below. Did I understand this correctly?
SIP-032 comparisonIncorporated into PoX-5 from Friedger's earlier SIP-032 for stacking improvements:
Left out of PoX-5:
|
|
@adriano-stacks and/or @brice-stacks, do you have links to PoX-5 and all of the testing and audits that were done? |
Hey @xyzerobtc! The audits are in progress and will be complete by end of month. PoX-5 is being implemented here (also reference |
No, the 1-cycle lock with auto-extend would over-complicate the implementation, so we went with allowing a number of cycles up to 96 (3-4 years), and stakers can unstake at any time (outside of prepare phases) and they will be unlocked in the next cycle.
The prepare phase is still 100 blocks, but no BTC is burned. It all goes to the pox-5 contract to be distributed!
Yes, no more separate delegation step.
Right, these are fulfilling the goal of SIP-032's design
The delegation is handled differently, so I think this renaming is no longer applicable. |
Thank you @adriano-stacks From @alexlmiller post: Jun 12 - Open Github PR with updated SIP draft Jun 15 - Jun 29 - Review period for public, Editors, CABs + CAB Votes Jul 1 - Jul 10 - Voting window (assuming CAB approval) Jul 29 - Target hardfork date (assuming vote passes) |
Updated the SIP information to include SIP-045 # in title and appendices per comments that this can be assigned prior to finalizing other requested revisions.
|
I opened a PR in my own fork with some suggested changes on the technical details - brice-stacks#1 EDIT: these are now merged here. |
|
Hey @brice-stacks I was chatting with @clairetopalian and wanted to ask, if we vote and approve SIP-045, would we need to have emergency fix after the audits are ready and something is needed as a fix? Similar to SIP 21, 22, and 23. SIP-021: Nakamoto: Fast and Reliable Blocks through PoX-assisted Block Propagation |
Any fixes would likely be just fixing the implementation, not the concept / design, so I wouldn't expect any SIP changes to be necessary. |
That sounds great @brice-stacks , wanted to make sure from a GOV CAB perspective -- if 2 votes were needed back to back, I think it would be best to only do 1 -- however, we don't need to cross that bridge anymore. Thanks |
Highlight SIP-032 changes merged into this SIP.
Editors have approved and the SIP can move to CAB votes.
|
@314159265359879, I'd like to go ahead and get this merged (as Accepted) so that the CAB vote happens against the merged version, not an open PR. Does that sound right to you? Same for #267. |
314159265359879
left a comment
There was a problem hiding this comment.
Thanks for the updates, congrats on the editor sign-off
No description provided.