Tweaks to Ubuntu Noble Upgrade (2024.1) #2099
Open
+21
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements commits: 9c85c3d and f23399c Update docs to get pulp to also publish and promote noble images Move repo additions to happen before do-release-upgrade Moves the addition of new Ubuntu repositories to directly before the call to do-release-upgrade. This ensures that any any failures after that point are only due to the upgrade itself, and not due to missing mounts (such as /tmp not being mounted).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements to the Ubuntu Noble upgrade process. The documentation is updated with a critical warning regarding Ceph versions and clarifies the commands for publishing and promoting Pulp repositories. The Ansible playbook for the upgrade is refactored to move the repository addition step, making the process more robust. My review includes suggestions to improve the readability of the updated documentation by reducing command repetition. Overall, these are valuable changes that enhance the clarity and reliability of the upgrade procedure.
seunghun1ee
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements commits: 9c85c3d and f23399c
Update docs to get pulp to also publish and promote noble images
Move repo additions to happen before do-release-upgrade
Moves the addition of new Ubuntu repositories to directly before the call to do-release-upgrade. This ensures that any any failures after that point are only due to the upgrade itself, and not due to missing mounts (such as /tmp not being mounted).