-
Notifications
You must be signed in to change notification settings - Fork 23
Tweaks to Ubuntu Noble Upgrade #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several tweaks for the Ubuntu Noble upgrade process. The documentation for Pulp repository synchronization is updated with necessary arguments. In the Ansible playbook for the upgrade, a task to add Noble repository definitions is moved to a more logical position. A critical comment has been kept regarding a broken task in the same playbook, which ensures /tmp is mounted with exec, due to missing parameters that would cause the playbook to fail. A suggestion to fix this has been provided.
Moves the addition of new Ubuntu repositories to directly before the call to do-release-upgrade. This ensures that any any failures after that point are only due to the upgrade itself, and not due to missing mounts (such as /tmp not being mounted).
f23399c to
b647332
Compare
|
@technowhizz are you planning on including all the changes from #1927? |
|
I didnt see that PR @Alex-Welsh |
|
happy to add to that PR if you think its better @Alex-Welsh |
I think the changes there are going to be stuck until someone from the stackhpc org re-creates the PR and this seems like a good opportunity to do it. If you could cherry-pick the changes and maybe squash them so it's not so many commits, that'd be great |
No description provided.