Fix infra VM NTP configuration by merging upstream unmaintained/2024.1 #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily consists of updates to comments and documentation across various configuration files, aligning them with upstream changes from the unmaintained/2024.1 branch. Key changes include clarifying default values, updating image URLs, and improving examples. The main functional change is the fix for NTP configuration on infrastructure VMs by adding the infra-vms group to the ntp configuration, as indicated by the pull request title. A release note for this fix has also been added. My review focuses on improving the clarity and correctness of some of the updated comments.
Alex-Welsh
approved these changes
Jan 22, 2026
Change-Id: Ied6385e21755cd289c16f098eb7fe87719521eba Signed-off-by: OpenStack Release Bot <infra-root@openstack.org> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/functions
Change-Id: I32a9cf99576fef2e4379606f90d2e9563e36b797 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Alex-Welsh
force-pushed
the
merge-upstream-2024.1
branch
from
79e2e51 to
a7479ab
Compare
Member
|
Merge conflict, rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.