Repository navigation
fix: spark connect extra class path - #755
Conversation
|
lfrancke
left a comment
There was a problem hiding this comment.
a "drive by" review. I didn't actually test the change but it looks sane to me in general. Thanks for catching.
Co-authored-by: Lars Francke <lars.francke@stackable.tech>
adwk67
left a comment
There was a problem hiding this comment.
Looks good, but there are test failures for spark-connect, probably due to the assertion at step 14 as there is now SPARK_CLASSPATH included as an env-var.
|
Hey, to me all local tests succeed. Can you link the pipeline run not running? Might be it's just image pull backoffs or something. |
I am getting (different from what I posted earlier) the following when the spark-connect app starts (on a fresh kind cluster): That pod is running with oci.stackable.tech/stackable/spark-connect-client:4.1.2-stackable0.0.0-dev |
|
Okay, I'm looking into it but so far it doesn't seem to be related to this specific PR. It seems like there are some different failures across tests which appear either flaky or lead to a successful state either way. Which means, I'll go after it but it's unrelated. |
|
I ran them all and they all failed, so I think it's more than flakiness. It's not caused by this PR but it sort of blocks approving it, though: I'll have a look to see if it's something with my setup. Update |
adwk67
left a comment
There was a problem hiding this comment.
LGTM!
I made local changes to fix the library pin issue:
--- PASS: kuttl (579.36s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/spark-connect_openshift-false_iceberg-latest-1.11.0_hive-iceberg-4.0.0_spark-connect-4.1.2_s3-use-tls-true (338.30s)
--- PASS: kuttl/harness/spark-connect-kerberos_openshift-false_iceberg-latest-1.11.0_hive-iceberg-4.0.0_spark-connect-4.1.2_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_s3-use-tls-true (241.04s)
PASS
I'll open an issue to address this in docker-images
|
Issue to fix the library conflict: #786 |
Description
Spark-connect: adds missing class patch of spark-connect in exectuer
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker