Repository navigation
chore!: Bump dependencies, including the RustCrypto stack - #1315
Merged
Merged
Conversation
Bump the RustCrypto crates together to their new generation (x509-cert 0.3, rsa 0.10.0-rc.19, ecdsa 0.17, p256 0.14, sha2 0.11, signature 3, const-oid 0.10, rand_core 0.10), alongside semver-compatible bumps. - Pin rsa exactly, as release candidates can contain breaking changes. - x509-cert 0.3 removed the Root and Leaf builder profiles. Port them to stackable-certs, so generated certificates stay unchanged apart from the extension order. Mark ExtendedKeyUsage as critical explicitly, as x509-cert no longer does so by default. - Replace OsRng with UnwrapErr(SysRng) and raise the RSA test key size to 1024 bits, the new minimum. - Use accessors for the now private x509-cert certificate fields. - Hex-encode the sha2 digest manually in ensure_max_string_length, as it no longer implements LowerHex. - Add FIXMEs for the infinitely recursing catch-all arms of the custom PartialEq impls in stackable-certs.
Techassi
reviewed
Oct 26, 2026
Techassi
left a comment
Member
There was a problem hiding this comment.
Partial review, I did not look at the new profile.rs and Cargo.toml files yet.
Co-authored-by: Techassi <git@techassi.dev>
Techassi
reviewed
Oct 27, 2026
Co-authored-by: Techassi <git@techassi.dev>
Techassi
reviewed
Oct 27, 2026
Techassi
left a comment
Member
There was a problem hiding this comment.
One last question, good to go otherwise.
Techassi
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump the RustCrypto crates together to their new generation (x509-cert 0.3, rsa 0.10.0-rc.19, ecdsa 0.17, p256 0.14, sha2 0.11, signature 3, const-oid 0.10, rand_core 0.10), alongside semver-compatible bumps.
Definition of Done Checklist
Author
Reviewer
Acceptance