Skip to content

Accept recursive symlinks with git-sync#1444

Open
Maleware wants to merge 3 commits intomainfrom
fix/airflow-symlink-acceptance
Open

Accept recursive symlinks with git-sync#1444
Maleware wants to merge 3 commits intomainfrom
fix/airflow-symlink-acceptance

Conversation

@Maleware
Copy link
Member

@Maleware Maleware commented Mar 6, 2026

Disclaimer:

the patch was initially created by claude and then got implemented by the author.

Description

This is a fix for Airflow 3.0.6 and Airflow 3.1.6 to tolerate symlink siblings within a core DAGs folder.

With stackabletech/airflow-operator#729 we want to allow multiple instances of git-sync ( and thus multiple git repositories to retrieve DAGs from ) for a single airflow installation.
Before this fix, we had to use a structure like

/stackable/app/allDAGs/current-0/<git-repository-structure> # Symlink from apps/git-0/current/

which arguably breaks some DAGs which would need to look at other files to execute their job ( e.g. spark-submit )

Now we can achieve:

/stackable/app/allDAGs/git-0/current/<git-folder> # Symlink from apps/git-0/

This will preserve previous structure but within another path allDAGs rather then git-0.

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@Maleware Maleware requested a review from adwk67 March 6, 2026 14:37
@Maleware Maleware self-assigned this Mar 6, 2026
@Maleware Maleware moved this to Refinement Acceptance: Waiting for in Stackable Engineering Mar 6, 2026
@Maleware Maleware moved this from Refinement Acceptance: Waiting for to Development: Waiting for Review in Stackable Engineering Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

1 participant