Skip to content

Add Trino Unit testcoverage and fix minor bugs #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bohreromir wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add Trino Unit testcoverage and fix minor bugs #374

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
298e8df
test: cover Trino API route handlers (#345)
Bohreromir Oct 8, 2026
cf3a744
test: cover Trino query store and script execution (#345)
Bohreromir Oct 8, 2026
a280fc3
test: cover per-user Trino connections (#345)
Bohreromir Oct 8, 2026
915fe71
fix: handle edge cases in Trino submit responses (#345)
Bohreromir Oct 8, 2026
d2b9c72
fix: stop superseded and cancelled Trino scripts between statements (…
Bohreromir Oct 8, 2026
2f22617
fix: treat a FAILED first Trino response without error as failure (#345)
Bohreromir Oct 8, 2026
9e9cdd0
fix: fail polled Trino queries reporting FAILED without error (#345)
Bohreromir Oct 8, 2026
dce1c05
fix: review feedback
Bohreromir Oct 12, 2026
306cdae
Merge branch 'main' into worktree-test-345-trino-api-coverage
Bohreromir Oct 12, 2026
76ef1c2
Merge branch 'main' into worktree-test-345-trino-api-coverage
Bohreromir Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/server/trino/queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ async function submitStatement(
const query: TrinoQuery = {
trinoQueryId,
// As in collectResults: don't expose a terminal state before all result pages
// are drained. startScript terminates the query once that has happened.
// are drained. The query is terminated once that has happened.
state: isTerminal(initialState) ? 'RUNNING' : initialState,
progress: toQueryProgress(submitResult.stats),
columns: submitResult.columns ?? [],
Expand Down
Loading