Repository navigation
Add each official plugin's license to its catalog releases - #41
Merged
Merged
Conversation
Copy the manifest's SPDX license into every release, and have release-entry.mjs write and check it so new releases keep it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for users
The plugin pages on onorca.dev show "License —" for most official plugins (Excalidraw, Spreadsheet, the themes, ...), because the site reads the license from the catalog release and only five releases had one. After this, every official plugin page shows its license.
Mechanism
orca-catalog.json: addslicenseto every release that lacked it, copied fromorca-plugin.jsonat that release's commit (all MIT; Gleam's existingMIT AND Apache-2.0is unchanged).licenseis a display-only release field in the v2 schema, so no commit,contentHashor plugin bytes change and nothing is re-pinned.scripts/release-entry.mjs: copies the manifest'slicenseinto the printed release, so--writeadds it for new plugins and the CI check fails if a release's license drifts from its manifest.orca-marketplace.jsonis untouched (the legacy export does not carrylicense).Why this approach
Putting it in the catalog avoids bumping versions and re-pinning releases, which editing manifests would require. The manifests already declare the right license and each plugin directory's LICENSE file is MIT.