docs: correct the GITHUB_TOKEN release flow - #16
Merged
Merged
Conversation
CI report
Ref: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the docs and the workflow comments claimed a
GITHUB_TOKENRelease PR "can never reportlint-testand can never be merged", and that a token was therefore required. That is wrong.GitHub exempts
pull_requestevents with theopened,synchronize, andreopenedactivity types: runs for aGITHUB_TOKEN-created PR start in an approval-required state rather than being suppressed, so approving them satisfieslint-testwithout bypassing anything.The real remaining constraint is different:
releaseis not an exempt event, so a release-please-created Release does not firerelease: published. Publishing is therefore a manual dispatch.Documents the actual flow — no secret, one approve click, one publish command — and keeps the token path as the way to remove both manual steps. Verified: dispatching release-please with no secret now returns
success, where the same dispatch was a403while the unauthorised PAT was still set.