ci: install e2e Go toolchain from e2e/go.mod - #89
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The e2e module (
e2e/go.mod) declaresgo 1.24.0/toolchain go1.24.4, but every workflow step that runs it pinnedsetup-gotogo-version: '1.23'. UnderGOTOOLCHAIN=localthe runner refuses to fetch a newer toolchain, sogo test ./...ine2e/exits 1 immediately:This hit both the standalone E2E workflow and the Orchestrate pipeline (
build-cli.yaml→E2E Testsjob). The scenarios themselves are healthy — the last tag run, which happened to resolveGOTOOLCHAIN=auto, shows all ofTestMultiStepScenariospassing.Fix
Drive the installed Go straight from
e2e/go.modviago-version-file(pluscache-dependency-path: e2e/go.sum) in every step that runs the e2e module, so the toolchain always matches the module requirement regardless ofGOTOOLCHAINmode and can't drift when thegodirective moves.Steps changed:
e2e.yaml—e2ejob setup-gobuild-cli.yaml—e2e-testsjob setup-go (Orchestrate path)Root-module jobs (the
buildjob inbuild-cli.yaml, pluspr.yaml,validate.yaml,release.yaml) stay on the rootgo.mod's 1.23 — they build./cmd/cascade, not the e2e module.Verification
actionlintclean on both edited workflows (the pre-existingjobs.e2e-tests.resultoutput warning is unrelated and present onmain)go build ./...and(cd e2e && go build ./...)cleangofmt -lclean