refactor(fleetreconcile): make the reconcile gate shell testable and cover its exit paths - #593
Merged
Merged
Conversation
…cover its exit paths Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fleet-reconcile gate binary's run() took an *os.File and called os.Exit(1) mid-function, leaving flag validation, JSONL ledger parsing, and the gate-failed exit path with no regression coverage (the untestable-CLI-shell class that previously shipped inert).
Refactor for testability with NO behavior change: run() now takes an io.Writer and returns (exitCode, err); os.Exit(code) lives only in main(); parseLedger(io.Reader) is extracted for in-memory testing. Exit codes (0 pass / 1 gate-fail / 2 tool-error), error strings, stderr prefix, and report output are byte-identical.
Adds hermetic table tests asserting exit code + message per branch (flag validation, input/ledger parse errors, gate PASS, gate FAIL) and a parseLedger table. Maintainer tooling, unit-only.
Verification: build/-race/lint green, 3081 tests; new branch tests fail-before/pass-after the refactor.