test: cover single-component byte-identical write, skip-ci marker, and backoff jitter - #545
Merged
Merged
Conversation
… jitter Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three load-bearing paths had no executing unit coverage:
WriteScopedStatewithComponent==""reachingapplySingleComponentWrites) was only proven transitively via a related wrapper, not driven directly, despite byte-identical single-component output being a hard invariant.[skip ci]marker on state commits (load-bearing for RC-tag trigger suppression) was asserted nowhere.Fix
Adds executing unit tests that drive the real paths:
WriteScopedStatesingle-component form asserts a flatstate.<env>leaf (nocomponents:nesting) and byte-identity against the whole-node oracle.[skip ci]is present on state commits and absent on the hotfix cherry-pick commit that must trigger CI.backoffForAttempt(git and statewrite) asserts per-attempt doubling, the 8s cap, and jitter bounds, deterministically with no real sleeping.No behavior change; the byte-identical invariant holds (characterization coverage).
Verification
go build ./...,go test ./...(2696 pass),golangci-lint run ./...all clean.