Skip to content

feat(hotfix,rollback): execute the per-component lifecycle in the harness and prove isolation - #528

Merged
joshua-temple merged 1 commit into
mainfrom
feat/lifecycle-e2e
Jul 8, 2026
Merged

joshua-temple merged 1 commit into
mainfrom
feat/lifecycle-e2e

Conversation

@joshua-temple

Copy link
Copy Markdown
Collaborator

Problem

Per-component hotfix and rollback runtime and generation are in place, but nothing proved they run in isolation end to end, and executing them surfaced composition gaps.

Fix

  • Harness: a scenario can trigger a named component's hotfix and rollback workflows (cascade-hotfix-<name>.yaml/cascade-rollback-<name>.yaml) and assert state.components.<name>.<env>, reusing the component-scoped state assertion. Single-component steps unchanged.
  • Hotfix plan state read: the planner never overlaid state.components.<name>.<env> into its working state, so a component-scoped hotfix plan failed with "no recorded state SHA" against a real multi-component manifest. It now overlays the component's recorded state, matching finalize and rollback.
  • Cherry-pick head branch: was hotfix/<env>/<sha> (not component-scoped); now hotfix/<component>/<env>/<sha>, byte-identical single-component, so two components hotfixing the same env and commit do not collide.
  • Harness commit-ref counter: shared its counter with internal bookkeeping and misnumbered a commit after a merge; now a dedicated counter.

Verification

go build ./..., go test ./... (2650 pass), golangci-lint run ./... clean; e2e build+vet clean; single-component byte-identical baseline gate green. New scenario 54-component-hotfix-rollback-isolation.yaml runs a full hotfix and rollback on one component asserting the sibling's subtree stays byte-unchanged, then mirrors it. Passes locally in the act and gitea harness (61s); a single-component hotfix scenario also passes locally (no flake).

Refs #293, #294, #296.

…ness and prove isolation

The act and gitea harness can now trigger a named component's hotfix and rollback workflows and assert state.components.<name>.<env>. A new scenario runs a full hotfix and a rollback on one component and asserts the sibling's recorded state stays byte-unchanged across it, then mirrors the cycle, proving per-component lifecycle isolation end to end. Proving it surfaced and fixed two composition gaps: the hotfix plan never overlaid the component's recorded state, so a component-scoped plan failed with no recorded SHA (now overlays state.components.<name>.<env>, matching finalize and rollback); and the cherry-pick head branch was not component-scoped (now hotfix/<component>/<env>/<sha>, byte-identical single-component). Single-component behavior is byte-identical.

Refs #293, #294, #296.

Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
@joshua-temple
joshua-temple merged commit 393529b into main Jul 8, 2026
20 checks passed
@joshua-temple
joshua-temple deleted the feat/lifecycle-e2e branch July 8, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant