feat(generate): fan out per-component hotfix and rollback workflows - #526
Merged
Merged
Conversation
When a manifest declares components, generate one hotfix-<name>.yaml and one rollback-<name>.yaml per component, mirroring the per-component orchestrate and promote fan-out, each emitting --component <name> so the hotfix and rollback commands run with component-scoped state, refs, and tags. A manifest with no components block generates the single hotfix and rollback workflows with no --component, byte-identical. The generate and verify paths share one fan-out helper for each so they cannot disagree. Refs #293, #294. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The hotfix and rollback runtimes accept
--component, but the generated workflows do not carry it, so per-component hotfix and rollback cannot run end to end for a multi-component repo.Fix
components:, generate onehotfix-<name>.yamland onerollback-<name>.yamlper component (mirroring the orchestrate and promote fan-out), each emitting--component <name>so the commands run with component-scoped state, refs, and tags.components:block generates the singlehotfix/rollbackworkflows with no--component, byte-identical.Plan) paths share one fan-out helper each, so they cannot disagree.Manually-dispatched hotfix/rollback fan out into per-component workflows, consistent with the shipped orchestrate and promote fan-out. The harness execution of a component's hotfix/rollback and the isolation-proof scenario are the next change.
Verification
go build ./...,go test ./...(2640 pass),go test ./... -raceclean,golangci-lint run ./...clean; e2e module build+vet clean. Single-component byte-identical baseline gate green. New e2e scenario53-component-hotfix-rollback-fanout.yaml(Per-Component Hotfix and Rollback Generation) passes locally in the act+gitea harness (24.9s): asserts eachhotfix-<name>.yaml/rollback-<name>.yamlexists and emits--component, and that no repo-widehotfix.yaml/rollback.yamlexists for a components manifest.Refs #293, #294.