feat(generate): fan out per-component promote workflows with isolated concurrency - #518
Merged
Merged
Conversation
… concurrency When a manifest declares components, generate one promote-<name>.yaml per component, mirroring the per-component orchestrate fan-out, each emitting --component so promotion computes and records that component's state. Each promote workflow gets its own concurrency namespace, promote-<name>, distinct from the orchestrate lane, so a component's promote never shares a repo-global lane with its orchestrate run. When a manifest sets a global concurrency group, the per-component promote composes it as <global>-promote-<name> so component identity is always present and isolation never collapses onto one literal lane. A manifest with no components generates a byte-identical single promote.yaml with no --component and the original group. The generate and verify paths share one fan-out helper so they cannot disagree. Refs #291. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With per-component promotion state recorded (#517), the generator must emit per-component promote workflows, each isolated so one component's promote never cancels or serializes another's. Two collision hazards exist: a component's resolved config carries the orchestrate concurrency group, and a manifest-global
concurrency.groupwould collapse every component onto one lane.Fix
components:, generate onepromote-<name>.yamlper component (mirroring the orchestrate fan-out), each emitting--component <name>.promote-<name>concurrency namespace, distinct from theorchestrate-<name>lane.concurrency.groupis set, the per-component promote composes it as<global>-promote-<name>so component identity is always present and isolation never collapses onto one literal lane.components:block generates a byte-identical singlepromote.yaml(no--component, original group).Plan) paths share one fan-out helper, so they cannot disagree.Verification
go build ./...,go test ./...(2584 pass),go test -raceon changed packages (1065 pass),golangci-lint run ./...clean; e2e module build+vet clean. Single-component byte-identical baseline gate green. New e2e scenario50-component-promote-fanout.yaml(Per-Component Promote Generation) passes locally in the act+gitea harness (23s): asserts eachpromote-<name>.yamlexists, carries its ownpromote-<name>group and--component, and that no repo-widepromote.yamlexists for a components manifest.Refs #291.