feat: add allow_breaking_changes manifest field to disable the breaking-change gate - #502
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
…ges is set Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
…breaking_changes is set Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The breaking-change promote gate (
feat!:/BREAKING CHANGE:commits block the prerelease-to-release and release-to-prod boundaries) can only be bypassed per-run today, via the--allow-breakingflag or theallow_breaking_changesworkflow input. A team that never wants the gate has no way to turn it off once. Closes #492.Fix
Add an additive, optional manifest field
allow_breaking_changes(bool, defaultfalse= gate enabled, so existing behavior is byte-identical). Whentrue, the gate is skipped for the repo without the per-run override; the per-run--allow-breakingflag and workflow input keep working as before.The gate is enforced in two places, both handled:
checkBreakingChangesForMode): short-circuits on the manifest field. The generatedpromote.yamldelegates tocascade promote preflight, so the CLI honoring the manifest covers the promote path.release.go): independently gates in bash offALLOW_BREAKING. The value is now baked from the manifest at generation time (ALLOW_BREAKING: "true"when the field is set), leaving the operator input declared. Default output is byte-identical (no drift in cascade's own workflows).Verification
go build ./...,go test ./... -race,golangci-lint run ./...all clean.internal/schema,schema/,docs/public/), guarded byTestSchema_OnDiskCopiesAreByteIdentical.49-allow-breaking-changes-manifestdrives afeat!:commit through promote with the manifest field set and no per-run override.Closes #492.