feat(taggrammar): canonical dependency-free tag grammar spec - #498
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shape of cascade's own release tags (
vX.Y.Z,-rc.N,.hotfix.M,-dryrun.N) is duplicated across six Go sinks that must agree by hand. There is no single source of truth, so the parser and the git tag predicate can drift apart. This is the foundation for making the grammar configurable (#434).Fix
Add a new leaf package
internal/taggrammarwith zero cascade imports (stdlib only): aSpecdescribing tag shape,Default()reproducing today's grammar byte-identically, and spec-drivenIsVersionTag,Parse, andFormat. No existing behavior changes; this is purely additive. Later milestones backinternal/versionandinternal/gitwith this package so the sinks can no longer diverge.Verification
go build ./...cleango test ./...green (2469 tests, purely additive)go test ./internal/taggrammar/ -racegreengolangci-lint run ./internal/taggrammar/cleanRelates to #434.