fix(ci): pass the action-pins path to the self-heal own-repo reconcile - #486
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The self-heal companion (
.github/workflows/pin-reconcile.yaml) invokescascade reconcile --own-repowithout--action-pins. That flag has nodefault (
internal/pinreconcile/command.go), so own-repo mode fails withreading action pins : open : no such file or directoryand never adoptsthe pin change.
Fix
Pass the canonical manifest path explicitly:
cascade reconcile --own-repo --action-pins internal/generate/action_pins.yaml.--own-repois cascade-only, so this is a workflow-only change; the companionalready runs the released binary that has the flag, so no new release is
needed.
Verification
Built the CLI from this branch and reproduced the trip locally: cloned a
fresh copy of
main, bumpedactions/create-github-app-token's sha in.github/workflows/action-pins.yml(leaving the manifest untouched), thenran the exact companion invocation from that copy.
internal/generate/action_pins.yamlpicked up the new sha/version foractions/create-github-app-tokencascade verifyreports3 files, no driftafterward--rootdefaults to.and--config/--manifest-keydefault safely for own-repo mode; only--action-pinshad no fallback.actionlinton the modified workflow: no findings.go build ./...: clean.