fix(ci): correct the self-heal companion release-asset pattern - #484
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Pin Reconcile companion (
.github/workflows/pin-reconcile.yaml) installed the pinned cascade CLI withgh release download -p 'cascade_linux_amd64.tar.gz'. goreleaser emits VERSIONED asset names (the real v0.9.0 asset iscascade_0.9.0_linux_amd64.tar.gz), so the unversioned pattern matched nothing, the download produced no file, andtar -xzf "$tmp"/*.tar.gzfailed the step. The self-heal push could never run.Fix
Change the asset pattern to
cascade_*_linux_amd64.tar.gz, matching the proven.github/actions/setup-clicomposite action exactly. The tar-extract glob, install path, andcascade versionlines already matched setup-cli.Audit
A full step-by-step comparison of the companion against
setup-cli/action.yamland the emitted generator logic ininternal/generate/reconcile_companion.gofound no other runtime defect:gh release list -L 1), extraction, install, and version print are consistent with setup-cli.fetch-depth: 0, which fetches all branches (+refs/heads/*:refs/remotes/origin/*) plus tags, so the base-branch tip resolved asbase_shais present locally andgit diff "$BASE_SHA" "$HEAD_SHA"resolves. Correct as-is.Verification
pin-reconcile.yamlandpr.yaml: zero findings.go build ./...: clean (no Go change).