fix(ci): pass changed files to the self-heal reconcile check and companion - #482
Merged
Merged
Conversation
…anion Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cascade's own self-heal reconcile wiring never received changed files, so it always no-op'd.
.github/workflows/pr.yamlrancascade reconcile --checkand.github/workflows/pin-reconcile.yamlrancascade reconcile --own-repowith no changed-file arguments.cascade reconcilereads governed pin bumps from files passed via repeated--changed-file <path>flags; with none, it scans nothing and always reports relevant=false, so the companion never actually reconciled. Caught by the intentional-trip proof.Fix
Mirror the already-correct emitted user template (internal/generate/reconcile_companion.go). Both hand-authored workflows now compute a
git diff --name-onlyof the PR's changed governed source files and pass each as--changed-file:.github/workflows/AND.github/actions/(cascade's own governed sources include composite actions), pass--changed-fileand write the artifact via--check-output pin-reconcile-result.json. Still advisory (non-gating).base_shafrom the resolved PR metadata, compute the same changed-file set, and thread--changed-fileintocascade reconcile --own-repo. No security property changed (pinned binary, state-token push, fork guard, loop guards, metadata-only PR resolution all intact).No generator or Go changes; the emitted templates were already correct. No release needed.
Verification
go build ./...clean (no Go changed).