fix(config): harden manifest input validation - #475
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
…spec allowlist Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
… refs Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several manifest-supplied values were passed into generated YAML and path joins without charset validation, so a malformed value could reach the generator unchecked.
Fix
Tightens validation on the affected manifest inputs, each with a failing-before/passing-after test:
action_pinsoverride values (a ref, optionally followed by# <version>); reject anything that could break out of the emitted scalar.action_folder(charset, no separators, no..), with a defense-in-depth guard in the generator before the path join...traversal and unsafe characters in local callback workflow paths across all accepted forms (bare filename,.github/workflows/..., andowner/repo/...@ref) via an up-front control/whitespace guard plus positive charsets.StagePathspec, a manifest-first pathspec allowlist so a future reconcile commit stages an explicit set of paths rather than everything.Verification
go build ./...,go test ./...(2382 passed),go test ./... -race,golangci-lint run ./...all clean.Part of #440.