fix(fleet): install the rc from the cascade repo, not the example repo - #469
Merged
Merged
Conversation
fleet-repin runs inside each example repo's suite, where github.repository is the example repo, but the cascade CLI release lives on stablekernel/cascade. The install step downloaded from the example repo and failed with 'release not found'. Add a cascade_repo input (default stablekernel/cascade) and download from it; push, checkout, and read-back still target the example repo. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fleet-repininstalls the dispatched rc CLI withgh release download --repo "$SELF_REPO"whereSELF_REPO = github.repository. The action runs inside each example repo's suite, so this targeted the example repo, which does not publish the cascade binary. A live self-repin failed at install withrelease not foundbefore any mutation.Fix
Add a
cascade_repoinput (defaultstablekernel/cascade) and download the rc from it. Push, checkout mutation, and read-back verify still target the example repo (SELF_REPO). No suite change needed; the default resolves the cascade repo.Verification
shellcheck clean. Regression gate is the pre-flip live suite prove: a manual
scenario-suitedispatch on cascade-example-2env with an rc reproduced this failure at the fleet-repin step; re-running after this fix confirms the self-repin commit lands and read-back passes. The act+gitea e2e harness cannot exercisegh release download, so the live prove is the authoritative check.