Skip to content

feat(fleet): add optional cascade_version inputs to dispatch-suite action - #466

Merged
joshua-temple merged 1 commit into
mainfrom
feat/dispatch-suite-version-inputs
Jul 5, 2026
Merged

joshua-temple merged 1 commit into
mainfrom
feat/dispatch-suite-version-inputs

Conversation

@joshua-temple

Copy link
Copy Markdown
Collaborator

Problem

A future fleet lane needs to forward the rc version under test (tag and
peeled commit sha) into a downstream example-repo suite's
workflow_dispatch. The dispatch-suite composite action has no place to
carry those values today.

Fix

Add two optional inputs to .github/actions/dispatch-suite/action.yaml,
cascade_version and cascade_version_sha, both empty by default. They
are plumbed into the step's env block and forwarded as -f args to
gh workflow run only when non-empty. No caller sets them yet and no
example-repo suite declares the inputs, so this is inert: every existing
fleet lane produces the exact same gh workflow run invocation as before.

Passing only when non-empty is load bearing: gh workflow run errors with
"unexpected inputs" if you pass an undeclared input, so an unconditional
pass would break every current suite.

Verification

  • shellcheck on the extracted embedded script: clean
  • go build ./... && go test ./... && golangci-lint run ./... at repo
    root: clean, unaffected
  • Manually confirmed the generated gh workflow run command is
    byte-for-byte identical to before when both new inputs are empty
    (the default)

Note: actionlint cannot parse composite action.yaml files as
workflows (it expects jobs/on); this is a pre-existing limitation
that also reproduces on the unmodified setup-cli/action.yaml, not a
regression from this change.

…tion

Add cascade_version and cascade_version_sha as optional, empty-by-default
inputs to the dispatch-suite composite action, forwarded to the target
suite's workflow_dispatch only when non-empty. No caller sets them yet
and no example-repo suite declares the inputs, so this is inert: every
fleet run stays byte-for-byte unchanged until a lane opts in.

Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
@joshua-temple
joshua-temple merged commit e9d6a0a into main Jul 5, 2026
15 checks passed
@joshua-temple
joshua-temple deleted the feat/dispatch-suite-version-inputs branch July 5, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant