feat(fleet): add optional cascade_version inputs to dispatch-suite action - #466
Merged
Merged
Conversation
…tion Add cascade_version and cascade_version_sha as optional, empty-by-default inputs to the dispatch-suite composite action, forwarded to the target suite's workflow_dispatch only when non-empty. No caller sets them yet and no example-repo suite declares the inputs, so this is inert: every fleet run stays byte-for-byte unchanged until a lane opts in. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A future fleet lane needs to forward the rc version under test (tag and
peeled commit sha) into a downstream example-repo suite's
workflow_dispatch. The dispatch-suite composite action has no place tocarry those values today.
Fix
Add two optional inputs to
.github/actions/dispatch-suite/action.yaml,cascade_versionandcascade_version_sha, both empty by default. Theyare plumbed into the step's env block and forwarded as
-fargs togh workflow runonly when non-empty. No caller sets them yet and noexample-repo suite declares the inputs, so this is inert: every existing
fleet lane produces the exact same
gh workflow runinvocation as before.Passing only when non-empty is load bearing:
gh workflow runerrors with"unexpected inputs" if you pass an undeclared input, so an unconditional
pass would break every current suite.
Verification
shellcheckon the extracted embedded script: cleango build ./... && go test ./... && golangci-lint run ./...at reporoot: clean, unaffected
gh workflow runcommand isbyte-for-byte identical to before when both new inputs are empty
(the default)
Note:
actionlintcannot parse compositeaction.yamlfiles asworkflows (it expects
jobs/on); this is a pre-existing limitationthat also reproduces on the unmodified
setup-cli/action.yaml, not aregression from this change.