docs(contributing): fleet suites must move with generator eligibility changes - #462
Merged
Merged
Conversation
…bility changes Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A change to the generator or CLI that alters which environments are eligible for an operation (for example, PR #418 making the first environment ineligible for rollback) can land without a matching update to the fleet example-repo suites that exercise that operation. The mismatch stays latent, since the affected fleet lane simply skips or no-ops, and only surfaces later as an apparently unrelated fleet failure on an unrelated change.
Fix
Add an explicit standard to the "Making a change" checklist in CONTRIBUTING.md: when a change alters the eligibility or validity of an operation on an environment, the fleet example-repo suites exercising that operation must be updated in the same change. A generator or CLI eligibility rule and the fleet suite asserting against it are treated as one coupled unit.
Verification
docs/src/content/docs/for a mirrored contributing or standards page; none exists (only incidental hits on the unrelatedcontributorsmanifest field), so no docs UI change is needed.