fix(config): match trigger globs with slash-native path.Match - #450
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared trigger-glob evaluator in
internal/config/triggers.gousedfilepath.Match, whose path separator is OS-specific. On Windows the separator is a backslash, so/is treated as an ordinary character and*matches across/. A cascade CLI run on Windows would over-match trigger patterns and disagree with the GitHub Actions paths filter (evaluated on Linux) that is generated from the same pattern list.Fix
Use
path.Match, which always treats/as the separator regardless of OS, so*is bounded to a single path segment everywhere. Behavior on Linux and macOS is unchanged; this aligns Windows CLI change detection with the emitted filter.Verification
go build ./...,go test ./... -race -count=1, andgolangci-lint run ./...all clean locally. Added table cases that lock the slash-boundary semantics (single*does not cross/).