fix(security): build with go1.26.4 to clear stdlib advisories - #445
Merged
Merged
Conversation
Pin the toolchain to go1.26.4 in both the root and e2e modules and drive every CI Go setup from the module files, so builds use the patched standard library. This closes the two reachable govulncheck stdlib advisories GO-2026-5039 (net/textproto) and GO-2026-5037 (crypto/x509), both fixed in go1.26.4. Add a govulncheck job to the validation gate so a reachable standard library advisory fails CI going forward. Update the docs prerequisites and release-verification steps to the new toolchain floor. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
govulncheck ./... reports two reachable Go standard-library advisories: GO-2026-5039 (net/textproto, reached via the hotfix PR checker) and GO-2026-5037 (crypto/x509). Both are DoS-class stdlib issues fixed in go1.26.4, but the build toolchain was go1.26.3 and CI pinned go-version: '1.25'.
Fix
Add a toolchain go1.26.4 directive to go.mod and e2e/go.mod, and switch the CI setup-go steps to go-version-file: go.mod so the build and CI use the intended toolchain. Add a Vulnerability Scan job to the validation workflow that runs govulncheck and gates the validation result. The go language directive stays at 1.25.
Verification
go build ./..., go test ./... -race -count=1, golangci-lint run ./..., and the e2e module go build/go vet all clean locally. govulncheck reports clean on go1.26.4.