test(e2e): add scenarios 42-44 covering consistency-fix, rollout strategy, and components reserve - #414
Merged
Conversation
…tegy, and components reserve Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
joshua-temple
force-pushed
the
test/e2e-coverage-gaps
branch
from
June 29, 2026 15:16
a26782b to
1ec15ca
Compare
joshua-temple
enabled auto-merge (squash)
June 29, 2026 15:21
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three feature-coverage gaps from epic #412 had no e2e regression guards:
status consistency --fixhad no e2e scenario verifying the orphan-branch delete pathmax_parallel/fail_fastgenerator path had no assertion testcomponentsreserve field (feat: independently versioned components in a single manifest #176) had no parse/generate smoke test (and its JSON schema entry was missing)Fix
Scenario 42 (
42-status-consistency-fix.yaml): seeds a divergedenv/prodbranch (stateref:set) and an orphanenv/devbranch (no manifest divergence), runscascade status consistency --fix, then asserts viagit ls-remote --heads origininside the act container thatenv/devis deleted andenv/prodis untouched. Confirmed--fixis strictly git (git push <remote> --delete) with no GitHub API path.Scenario 43 (
43-deploy-rollout-strategy.yaml): manifest setsrollout.max_parallel: 2androllout.fail_fast: trueon a deploy with aninputsmap (required for the matrix path where the strategy block renders). Assertspromote.yamlcontainsfail-fast: trueandmax-parallel: 2.Scenario 44 (
44-components-reserved.yaml): mirrors the 23-26 reserved-shape pattern for thecomponentsreserve. Fixes the missing JSON schema entry (componentConfigdefinition +componentsproperty) so the field passes schema validation; also regenerates both distribution schema copies.Gap #5 (auto-promote handoff): assessed only. The resolve/full-run logic is entirely shell in
.github/workflows/auto-promote.yaml(artifact download, regex matching,gh apitag lookup,${RC%-rc.*}suffix stripping). No Go backs it. Faithful coverage requires a real GitHub Actions run with a real rc tag and a completed fleet run. Left for the fleet track.Verification
Status_Consistency_Fix_Deletes_Orphan_Env_Branch: PASS (22.66s, Docker)Deploy_Rollout_Strategy_Options: PASS (21.40s, Docker)Components_Reserved_Shape: PASS (21.43s, Docker)go build ./...: exit 0go test ./...: exit 0golangci-lint run ./...: exit 0 (0 issues)e2e: go build ./... && go vet ./...: exit 0