Skip to content

test(e2e): add scenarios 42-44 covering consistency-fix, rollout strategy, and components reserve - #414

Merged
joshua-temple merged 1 commit into
mainfrom
test/e2e-coverage-gaps
Jun 29, 2026
Merged

joshua-temple merged 1 commit into
mainfrom
test/e2e-coverage-gaps

Conversation

@joshua-temple

Copy link
Copy Markdown
Collaborator

Problem

Three feature-coverage gaps from epic #412 had no e2e regression guards:

Fix

Scenario 42 (42-status-consistency-fix.yaml): seeds a diverged env/prod branch (state ref: set) and an orphan env/dev branch (no manifest divergence), runs cascade status consistency --fix, then asserts via git ls-remote --heads origin inside the act container that env/dev is deleted and env/prod is untouched. Confirmed --fix is strictly git (git push <remote> --delete) with no GitHub API path.

Scenario 43 (43-deploy-rollout-strategy.yaml): manifest sets rollout.max_parallel: 2 and rollout.fail_fast: true on a deploy with an inputs map (required for the matrix path where the strategy block renders). Asserts promote.yaml contains fail-fast: true and max-parallel: 2.

Scenario 44 (44-components-reserved.yaml): mirrors the 23-26 reserved-shape pattern for the components reserve. Fixes the missing JSON schema entry (componentConfig definition + components property) so the field passes schema validation; also regenerates both distribution schema copies.

Gap #5 (auto-promote handoff): assessed only. The resolve/full-run logic is entirely shell in .github/workflows/auto-promote.yaml (artifact download, regex matching, gh api tag lookup, ${RC%-rc.*} suffix stripping). No Go backs it. Faithful coverage requires a real GitHub Actions run with a real rc tag and a completed fleet run. Left for the fleet track.

Verification

  • Scenario 42 Status_Consistency_Fix_Deletes_Orphan_Env_Branch: PASS (22.66s, Docker)
  • Scenario 43 Deploy_Rollout_Strategy_Options: PASS (21.40s, Docker)
  • Scenario 44 Components_Reserved_Shape: PASS (21.43s, Docker)
  • go build ./...: exit 0
  • go test ./...: exit 0
  • golangci-lint run ./...: exit 0 (0 issues)
  • e2e: go build ./... && go vet ./...: exit 0

…tegy, and components reserve

Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
@joshua-temple
joshua-temple force-pushed the test/e2e-coverage-gaps branch from a26782b to 1ec15ca Compare June 29, 2026 15:16
@joshua-temple
joshua-temple enabled auto-merge (squash) June 29, 2026 15:21
@joshua-temple
joshua-temple merged commit c7a87c0 into main Jun 29, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant