fix(release): require --sha only for tag-creating manage-release actions - #346
Merged
Merged
Conversation
manage-release validated --sha as required for every action, but lock, update, and delete resolve the release by tag (SHA is only an optional disambiguator); only create, prerelease, and publish tag a commit and genuinely need it. The over-strict check made the generator's emitted 'manage-release --action delete --sha ""' always error (masked by '|| true'), and broke a lock verb on the fleet. Gate the requirement to the tag-creating actions. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cascade manage-releasevalidated--shaas required for every action, but onlycreate/prerelease/publishtag a commit and need it.lock/update/deleteresolve the release by tag (SHA is only an optional disambiguator). The over-strict check made the generator's own emittedmanage-release --action delete --sha "" --tag ... || truealways error (masked by|| true), and broke alockverb on the live fleet (surfaced by new primary suite coverage).Fix
Extract
validateManageReleaseFlags; gate the--sha is requiredcheck to{create, prerelease, publish}only.repo/action/environment/tagstay required. New unit test asserts lock/update/delete validate without--shawhile create/prerelease/publish still require it (RED→GREEN, 8 subtests). Build +go test ./...+ golangci-lint clean.Closes the primary-fleet lock/delete failure. The integration exercise is the primary suite's lock/delete verbs.