fix(fleet): download ledger artifacts per-subdir so multi-job ledgers do not clobber - #276
Merged
Merged
Conversation
… do not clobber Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each register-run upload names its artifact uniquely but the file inside is always cascade-run-ledger.jsonl. fleet-reconcile downloaded with merge-multiple, which flattens all artifacts into one directory, so the identically-named files overwrote each other and only one job's ledger survived. Multi-job suites (3env/2env/4env) therefore saw their genuinely-registered runs as unregistered and the gate red. Single-job suites use the in-workspace path and were unaffected (and passed). Fix: drop merge-multiple so each artifact lands in its own subdirectory; the assemble step's existing recursive find -exec cat concatenates one ledger per job. Fleet infra only. The live rc.28 fleet run surfaced this.