feat: add notify deploy_name and environment overrides - #267
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Build-only satellites derive the cross-repo notify dispatch deploy_name from their local build name and environment from dev, which the parent rejects when it knows the satellite under a different external-deploy name and environment. The fleet coverage gate surfaced this: artifact-a (build named shared, no environments) dispatched deploy_name=shared/environment=dev, which primary rejects as an unknown external deploy, failing every notify run.
Fix
Adds two optional notify fields, deploy_name and environment, so a satellite can dispatch the parent-recognized names. Both are additive and omitempty; when unset, generation is byte-identical to today and schema_version is unchanged. Covered by config round-trip tests, a generator test asserting the overrides are emitted, and an off-state byte-identical test; docs and the manifest JSON Schema (all 3 synced copies) updated.
Follow-up: set notify.deploy_name/environment in the artifact-a/b example manifests so the next repin produces valid dispatches.