fix: complete hotfix-rejoin cleanup for published releases - #264
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
joshua-temple
enabled auto-merge (squash)
June 23, 2026 19:02
…ario Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An adversarial audit (prompted by recurring one-per-rc fleet failures) found the hotfix rejoin/finalize cleanup path could wedge or leak objects:
Fix
AllowPublishedDeleteopt-in used only by rejoin cleanup; the general delete guard for normal published releases stays in force.Verification
Full unit suite (1725 passed), golangci-lint clean, e2e module builds/vets, and a new
hotfix-rejoin-prerelease-supersedee2e scenario exercises the prerelease-env supersede/rejoin. The general delete guard is proven intact by a negative test. schema_version unchanged; no manifest field; no generated-workflow change.A confirmed same-rc-base cross-env cleanup scoping gap is documented for a focused follow-up (the env SHA is already plumbed for it).