test(e2e): raise TestActRunner_Start deadline to 5m for cold image pulls - #262
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestActRunner_Start used a 2-minute context deadline for NewActRunner, which pulls the act runner image. On a fresh runner the first cold image pull can exceed two minutes, timing out with 'context deadline exceeded' during create container; the next test reuses the warmed image and passes. This caused intermittent Integration failures. Raise the deadline to 5 minutes, matching the sibling TestActRunner_RunWorkflow, so the bare-start test does not flake on the first pull. Test-only timing change.