fix: eliminate eventual-consistency race in multi-env hotfix finalize - #259
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When finalizing a hotfix across multiple environments, the second env's Finalize Hotfix step failed with "no release found for tag v1.0.0-rc.0.hotfix.2" even though the draft release existed. GitHub's GET /releases/tags/{tag} returns 404 for drafts, and the GET /releases list endpoint has a propagation window of a few seconds after draft creation, so the second env reliably lost the race while the first succeeded by chance. The live fleet caught it on v0.3.0-rc.20.
Fix
Verification
New unit tests stub a server where the by-tag endpoint always 404s and the list is empty on the first call; the create-then-prerelease sequence now succeeds, and neutralizing prong 1 reproduces the exact "no release found" failure. The act+gitea e2e cannot reproduce this (gitea skips the prerelease PATCH path and has no list-consistency window), so the stubbed-client unit test is the regression guard. Full suite green, lint clean, schema_version unchanged. Single-env hotfix finalize path unaffected.