feat: default release_token to state_token to arm the rc-to-release chain - #258
Merged
Merged
Conversation
…hain Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
joshua-temple
enabled auto-merge (squash)
June 23, 2026 00:21
…e-token-default scenario sets it Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When state_token is a trigger-capable PAT or App token (for protected-trunk writes) but release_token is left unset, release_token defaulted to secrets.GITHUB_TOKEN. GitHub suppresses workflow triggers for ref-creations made with GITHUB_TOKEN, so the rc tag fired nothing and the Release pipeline died silently.
An unset release_token now inherits the state_token expression when one is set, reusing the trigger-capable token already configured. Both-unset keeps the historical GITHUB_TOKEN default; an explicit release_token still wins. App-backed-only state tokens keep the default and are documented to set a static release_token.
Coverage: config table tests, generator tests (defaults-to-state plus both-unset back-compat), an orchestrate e2e scenario, and a docs caution box. Schema version unchanged; no new manifest field. cascade's own workflows are unchanged (its manifest sets release_token explicitly).
Closes #255