feat: emit least-privilege top-level workflow permissions - #251
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generated workflows carried
contents: write(andactions: write) at the top level, so OSSF Scorecard flagged high-severity TokenPermissions; every job inherited write scope.Fix
The generator now emits a least-privilege top-level default (
contents: read) and pushes write scopes down to only the jobs that need them: orchestrate finalize getscontents: write(plusdeployments: writefor native deployments); promote finalize getscontents: writeandactions: write; the hotfix and rollback committing jobs get their writes job-scoped. This extends the same least-privilege approach as the merged callback-permissions work (#204) from callback scopes to cascade's own base orchestration scopes. Reusable-workflow caller jobs keep their declared permissions includingid-token: writefor OIDC.Verification
go test ./... (1678 pass); golangci-lint clean; e2e build/vet clean; a new Docker e2e scenario asserts top-level
contents: readwith job-level writes (PASS), and the OIDC callback scenario still passes. cascade verify reports no drift on the regenerated workflows. schema_version unchanged.Addresses the Scorecard TokenPermissions alerts on the generated orchestrate and promote workflows. The hand-authored hotfix.yaml (alert #2) is handled separately.