ci: use cascade verify for the dogfood workflow drift check - #227
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The workflow-drift job regenerated workflows to a temp tree and diffed them by hand. This approach required write permissions (the --force flag) and was duplicating logic already in cascade itself.
Fix
Replace the generate-and-diff steps with a single
cascade verifycall. The verify command is read-only, exits 0 on a clean tree and 1 on drift, and needs onlycontents: read- making it safe for fork PRs. The required PR gate membership is unchanged.Verification
go run ./cmd/cascade verify --config .github/manifest.yamlexits 0 on the committed tree