fix(e2e): anchor localize verify to the action ref it rewrites - #200
Merged
Merged
Conversation
The post-localize verify grepped for a bare stablekernel/cascade substring, which also matches the verbatim cross-repo callback ref stablekernel/cascade-example-artifact-a/.github/workflows/...@main in the cross-repo scenario. That ref is intentionally left untouched, so verify flagged it as un-localized and failed repo staging after three attempts, failing the e2e suite deterministically. Anchor the verify pattern to the exact action ref the sed rewrites (stablekernel/cascade/.github/actions/) so a sibling-repo callback is no longer mistaken for an un-localized ref. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dogfooded
Orchestrate CI/CDe2e suite onmainfails deterministically at theCross-Repo Reusable-Workflow Callbackscenario during repo staging:The post-localize verify greps for a bare
stablekernel/cascadesubstring. That also matches the verbatim cross-repo callback refstablekernel/cascade-example-artifact-a/.github/workflows/build-shared.yaml@mainemitted by scenario 21. That ref is intentional and the sed leaves it untouched, so verify flagged it as un-localized and failed all three attempts.This is a latent failure introduced when the cross-repo scenario landed; it is not caused by the two most recent merges (the PR-preview and hotfix-label changes both pass in isolation and in this run). The named suspects were red herrings.
Fix
Anchor the verify pattern to the exact ref the sed rewrites,
stablekernel/cascade/.github/actions/. The trailing/.github/actions/distinguishes the localizable action ref (slash aftercascade) from the distinctcascade-example-artifact-arepo (hyphen aftercascade). A sibling-repo callback is no longer mistaken for an un-localized ref.Verification
Cross-Repo Reusable-Workflow Callbacke2e scenario passes locally in Docker (act + gitea):--- PASS: TestMultiStepScenarios/Cross-Repo_Reusable-Workflow_Callback (18.59s)PR_Preview_WorkflowandHotfix_Conflict_Resolution.TestUnlocalizedActionRefPattern_IgnoresCrossRepoCallbacklocks the verify pattern against the sibling-repo and same-repo cross-repo refs.go build ./...,go test ./...(e2e harness),go vet, andgolangci-lint run ./...pass on the changed code and the e2e module.Note:
internal/generate/TestNormalizeWorkflowPath_ActionlintCleanfails on this machine with actionlint 1.7.12 resolving relative reusable-workflow paths against the repo root; it fails identically on pristinemainand is unrelated to this change.