test(e2e): prove init-scaffolded topology orchestrates and promotes - #171
Merged
Merged
Conversation
…hestrates and promotes Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The scaffold package's SelfCheck statically proves a
cascade initmanifest parses, validates, and generates, but nothing proved the scaffolded pipeline actually runs. Static generation cannot catch manifest-shape drift that only surfaces at runtime.Fix
Adds an e2e scenario (
e2e/init_scaffold_test.go) that renders the real two-environment [dev prod] topology viascaffold.Scaffold, unmarshals the live scaffolded manifest'sci.configinto the harness Config (so the run is bound to the exact scaffold output, not a hand-copied fixture), and drives it through act and gitea:v0.1.0-rc.0, a draft prerelease is cut at devv0.1.0published, rc tag deleted, dev unchangedCallback bodies are supplied via
SetupWorkflowsmirroring the scaffold contract (build emitsartifact_id; both take the environment/sha/dry_run inputs) but withoutactions/checkout, which act cannot resolve for a reusable callback against the per-scenario gitea. This matches the no-checkout pattern the existing runtime scenarios already document and use.Verification
go build ./...,go vet ./...,go test ./...(1345 pass),golangci-lint run ./...cleango build ./...,go vet ./...,golangci-lint run ./...cleango test -run TestInitScaffoldOrchestratesAndPromotes -timeout 20m ./...passes (orchestrate + both promotes green, state advances dev -> release -> prod)