fix: pin cascade self-action ref to immutable version tag - #151
Merged
Merged
Conversation
…ble @latest Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The self-action
stablekernel/cascade/.github/actions/setup-cliwas referenced at the mutable@latest/@masterref by default. A compromise of this action repo would execute in every consumer's CI without any explicit version pinning.Fix
DefaultCLIVersion = "v0.1.0"constant ininternal/configas the maintained source-of-truth pin (the latest stable tag).GetCLIVersion()now returnsDefaultCLIVersionwhencli_versionis unset or explicitly set to"latest". The"beta"value remains as an explicit, opt-in escape hatch that resolves to@master.getCLIRef()methods updated to be consistent with the new default. Explicit version tags (vX.Y.Z) pass through unchanged.cli_versionin the cascade manifest.Bumping the pin on release
Update
DefaultCLIVersionininternal/config/types.goas part of the release process when a new stable tag is created.Verification
TestGetCLIVersionandTestGetCLIRef_DefaultIsPinnedNotMutablego build ./... && go test ./...- passcd e2e && go build ./... && go vet ./...- passgolangci-lint run ./...- clean