ci: upload e2e crash evidence artifacts - #148
Merged
Merged
Conversation
The e2e harness writes the last attempt's raw act stdout/stderr to e2e/_artifacts/<scenario>-attempt<N>.log when a scenario exhausts its retries, but the E2E workflow never uploaded it, so the stack-trace evidence was lost once the CI log retention window expired. Add an upload-artifact step (if: always(), if-no-files-found: ignore, 14-day retention) so the evidence is recoverable. Pinned to the same SHA convention used elsewhere in the repo. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#146 added retry-exhaustion evidence capture: the e2e harness writes the last attempt's raw act stdout/stderr to
e2e/_artifacts/<scenario>-attempt<N>.logso the stack-trace origin survives the CI log retention window. But.github/workflows/e2e.yamlnever uploaded that directory, so on a CI failure the evidence was lost once the log window expired. The capture path was effectively unused on CI.Fix
Add an
actions/upload-artifactstep to the E2E Tests job, after the e2e test run step:if: always()so evidence is recoverable whether the job failed or a flake was absorbed.path: e2e/_artifacts/(repo-relative; the test step runs inworking-directory: e2e, so captures land undere2e/_artifacts/).if-no-files-found: ignoreso a run where no scenario exhausted its retries is a clean no-op.retention-days: 14.Pinned to
actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1, matching the SHA-pin-with-version-comment convention already used in the repo (same pin asscorecard.yml).Verification
This is a CI-config change with no Go surface, so the "ships a test" bar is satisfied by
actionlint:actionlint .github/workflows/e2e.yamlpasses with exit 0 and no findings.