feat: add divergence fields to EnvState - #100
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EnvState has no way to record that an environment is on a hotfix integration branch rather than trunk. Three fields are needed to track the hotfix ref, the base SHA the branch diverged from, and the list of patch commits applied.
Fix
Add
Ref,BaseSHA, andPatchesfields toEnvState(all omitempty, additive - no schema version bump per the policy at types.go). AddIsDiverged() boolmethod that returns true whenRefis set orPatchesis non-empty. Surface the fields incascade statusoutput only when set.Verification
All green. Existing manifest fixtures parse without diff (IsDiverged()==false on all).