Skip to content

fix(orchestrate): git.GetLatest* run in process cwd, not o.baseDir #387

Description

@joshua-temple

Noted during the version-discovery fix (#382). internal/orchestrate/orchestrator.go calls git.GetLatestTag/GetLatestReleaseTag in the process working directory rather than o.baseDir, which is why a stray dryrun tag in the cascade checkout broke the orchestrate unit tests. The version-format filter neutralizes the crash, but the cwd-vs-baseDir inconsistency is real and should be made explicit (pass baseDir through, or document why cwd is correct).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions